Bug 24027 - Do not send loader callbacks during CSS styling
Summary: Do not send loader callbacks during CSS styling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-19 10:15 PST by Cameron Zwarich (cpst)
Modified: 2009-04-24 12:35 PDT (History)
2 users (show)

See Also:

Attachments
Suspend memory client callbacks during attach() and recalcStyle() (9.62 KB, patch)
2009-02-19 11:02 PST, mitz 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2009-02-19 10:15:16 PST 
Currently loader callbacks are sent during CSS styling, e.g. if a CSS background image is loaded from the cache. Since styling is not reentrant and loader callbacks may provoke CSS styling from the WebKit client, this is not safe. The fix is to delay sending the callbacks until styling has completed. See the discussion in bug 22521 for more details.

This caused crashes with iChat, which were fixed by Mitz with a workaround in r41071. I assigned this bug to him because he has the best idea of how to make the correct fix.
Comment 1 mitz 2009-02-19 11:02:30 PST 
Created attachment 27798 [details]
Suspend memory client callbacks during attach() and recalcStyle()
Comment 2 mitz 2009-02-19 11:05:20 PST 
I intend to change Reenable to ReEnable.
Comment 3 mitz 2009-02-19 17:42:48 PST 
Fixed in <http://trac.webkit.org/projects/webkit/changeset/41096>.