RESOLVED FIXED 240268
[Cocoa] fast/text/international/generic-font-family-language-traditional.html is failing due to language minimization 
https://bugs.webkit.org/show_bug.cgi?id=240268
Summary [Cocoa] fast/text/international/generic-font-family-language-traditional.html...
Chris Dumez
Reported 2022-05-09 21:11:19 PDT
fast/text/international/generic-font-family-language-traditional.html is failing due to language minimization.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-05-16 21:12:13 PDT
<rdar://problem/93394618>
Myles C. Maxfield
Comment 2 2022-05-20 18:58:05 PDT
cachedUserPrefersSimplified() should probably say static bool cached = computeUserPrefersSimplified(); instead of static bool cached = false;
Myles C. Maxfield
Comment 3 2022-05-20 19:12:26 PDT
This is kind of interesting. We're saying the language list ["en", "zh-tw"] gets minimized to ["en"], which then removes the signal about whether we should render simplified or traditional Chinese. On one hand, this is kind of good, because the whole point of minimization is to make different browser configurations in the same bucket as identical. On the other hand, it means a user with these language preferences won't get the rendering they expect. I could change the test to just use the language list ["zh-tw"] and I think it would still test the thing it's trying to test, so I guess that's probably the path forward. 🤔
Myles C. Maxfield
Comment 4 2022-05-20 19:14:43 PDT
*** Bug 240751 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 5 2022-05-20 19:17:06 PDT
*** Bug 240751 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 6 2022-07-11 18:55:03 PDT
Landed in https://commits.webkit.org/250878@main.
Note You need to log in before you can comment on or make changes to this bug.