Bug 240246 - Const-ify Node::willRespondTo*Events()
Summary: Const-ify Node::willRespondTo*Events()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-09 12:26 PDT by Tim Horton
Modified: 2022-05-09 16:52 PDT (History)
20 users (show)

See Also:

Attachments
Patch (33.31 KB, patch)
2022-05-09 12:27 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (33.47 KB, patch)
2022-05-09 12:30 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (35.65 KB, patch)
2022-05-09 13:12 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.66 KB, patch)
2022-05-09 13:45 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-05-09 12:26:14 PDT 
Const-ify Node::willRespondTo*Events()
Comment 1 Tim Horton 2022-05-09 12:27:04 PDT 
Created attachment 459067 [details]
Patch
Comment 2 Wenson Hsieh 2022-05-09 12:29:46 PDT 
Comment on attachment 459067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459067&action=review

> Source/WebCore/html/HTMLPlugInElement.h:66
>      bool willRespondToMouseMoveEvents() final { return false; }

Looks like we're missing a const here too?
Comment 3 Tim Horton 2022-05-09 12:30:46 PDT 
Created attachment 459068 [details]
Patch
Comment 4 Tim Horton 2022-05-09 13:12:33 PDT 
Created attachment 459073 [details]
Patch
Comment 5 Tim Horton 2022-05-09 13:45:52 PDT 
Created attachment 459080 [details]
Patch
Comment 6 EWS 2022-05-09 16:51:30 PDT 
Committed r293993 (250430@main): <https://commits.webkit.org/250430@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459080 [details].
Comment 7 Radar WebKit Bug Importer 2022-05-09 16:52:13 PDT 
<rdar://problem/92993954>