Bug 240244 – Remove abandoned CSSDeferredParser implementation and feature flag

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

This patch rolls out the abandoned CSSDeferredParser implementation added in Bug 165743.

[Brent Fulgham]

Created attachment 459064 [details]
Patch

[Brent Fulgham]

@Antti: Should we do something about removing the SPECIALIZE_TYPE_TRAITS bits that were added in Hyatt's original patch?

[Antti Koivisto]

Comment on attachment 459064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459064&action=review

Nice cleanup!

> Source/WebCore/css/StyleProperties.h:337
>  SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::StyleProperties)
> -    static bool isType(const WebCore::StylePropertiesBase& set) { return set.type() != WebCore::DeferredPropertiesType; }
> +    static bool isType(const WebCore::StylePropertiesBase&) { return true; }
>  SPECIALIZE_TYPE_TRAITS_END()

I think we can just remove StylePropertiesBase and smash it into StyleProperties.

Doesn't need to be done in this patch.

[Tim Nguyen (:ntim)]

(In reply to Antti Koivisto from comment #3)
> I think we can just remove StylePropertiesBase and smash it into
> StyleProperties.
> 
> Doesn't need to be done in this patch.

Worth filing a bug.

[Brent Fulgham]

Comment on attachment 459064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459064&action=review

>> Source/WebCore/css/StyleProperties.h:337
>>  SPECIALIZE_TYPE_TRAITS_END()
> 
> I think we can just remove StylePropertiesBase and smash it into StyleProperties.
> 
> Doesn't need to be done in this patch.

Filed Bug 240282. Will do that after this patch lands.

[EWS]

Committed r294007 (250443@main): <https://commits.webkit.org/250443@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459064 [details].

[Radar WebKit Bug Importer]

<rdar://problem/93035841>