Bug 240244 - Remove abandoned CSSDeferredParser implementation and feature flag
Summary: Remove abandoned CSSDeferredParser implementation and feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 165743
Blocks: 240282
  Show dependency treegraph
 
Reported: 2022-05-09 11:42 PDT by Brent Fulgham
Modified: 2022-05-10 09:50 PDT (History)
16 users (show)

See Also:


Attachments
Patch (94.85 KB, patch)
2022-05-09 11:56 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-05-09 11:42:42 PDT
This patch rolls out the abandoned CSSDeferredParser implementation added in Bug 165743.
Comment 1 Brent Fulgham 2022-05-09 11:56:54 PDT
Created attachment 459064 [details]
Patch
Comment 2 Brent Fulgham 2022-05-09 11:58:04 PDT
@Antti: Should we do something about removing the SPECIALIZE_TYPE_TRAITS bits that were added in Hyatt's original patch?
Comment 3 Antti Koivisto 2022-05-09 21:14:43 PDT
Comment on attachment 459064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459064&action=review

Nice cleanup!

> Source/WebCore/css/StyleProperties.h:337
>  SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::StyleProperties)
> -    static bool isType(const WebCore::StylePropertiesBase& set) { return set.type() != WebCore::DeferredPropertiesType; }
> +    static bool isType(const WebCore::StylePropertiesBase&) { return true; }
>  SPECIALIZE_TYPE_TRAITS_END()

I think we can just remove StylePropertiesBase and smash it into StyleProperties.

Doesn't need to be done in this patch.
Comment 4 Tim Nguyen (:ntim) 2022-05-10 09:25:02 PDT
(In reply to Antti Koivisto from comment #3)
> I think we can just remove StylePropertiesBase and smash it into
> StyleProperties.
> 
> Doesn't need to be done in this patch.

Worth filing a bug.
Comment 5 Brent Fulgham 2022-05-10 09:36:23 PDT
Comment on attachment 459064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459064&action=review

>> Source/WebCore/css/StyleProperties.h:337
>>  SPECIALIZE_TYPE_TRAITS_END()
> 
> I think we can just remove StylePropertiesBase and smash it into StyleProperties.
> 
> Doesn't need to be done in this patch.

Filed Bug 240282. Will do that after this patch lands.
Comment 6 EWS 2022-05-10 09:49:43 PDT
Committed r294007 (250443@main): <https://commits.webkit.org/250443@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459064 [details].
Comment 7 Radar WebKit Bug Importer 2022-05-10 09:50:14 PDT
<rdar://problem/93035841>