Bug 240231 - Add a better mock for audio units used by CoreAudioSharedUnit
Summary: Add a better mock for audio units used by CoreAudioSharedUnit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-09 06:22 PDT by youenn fablet
Modified: 2022-05-12 07:29 PDT (History)
12 users (show)

See Also:

Attachments
Patch (81.98 KB, patch)
2022-05-09 06:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (81.91 KB, patch)
2022-05-10 05:32 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (81.93 KB, patch)
2022-05-10 05:48 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (81.96 KB, patch)
2022-05-10 05:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (81.93 KB, patch)
2022-05-12 04:16 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-05-09 06:22:12 PDT 
Add a better mock for audio units used by CoreAudioSharedUnit
Comment 1 youenn fablet 2022-05-09 06:55:29 PDT 
Created attachment 459041 [details]
Patch
Comment 2 youenn fablet 2022-05-10 05:32:39 PDT 
Created attachment 459111 [details]
Patch
Comment 3 youenn fablet 2022-05-10 05:48:14 PDT 
Created attachment 459112 [details]
Patch
Comment 4 youenn fablet 2022-05-10 05:53:51 PDT 
Created attachment 459113 [details]
Patch
Comment 5 Eric Carlson 2022-05-10 06:28:21 PDT 
Comment on attachment 459113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459113&action=review

> Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:266
> +    auto sampleTime = PAL::toMediaTime(startTime).toFloat();

Can you just use `sampleTime = PAL::CMTimeGetSeconds(startTime)`?
Comment 6 youenn fablet 2022-05-11 00:11:22 PDT 
(In reply to Eric Carlson from comment #5)
> Comment on attachment 459113 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459113&action=review
> 
> > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:266
> > +    auto sampleTime = PAL::toMediaTime(startTime).toFloat();
> 
> Can you just use `sampleTime = PAL::CMTimeGetSeconds(startTime)`?

Yes, that seems better.
Comment 7 youenn fablet 2022-05-11 00:12:24 PDT 
Comment on attachment 459113 [details]
Patch

win failure is unrelated. Marking as r?
Comment 8 youenn fablet 2022-05-12 04:16:17 PDT 
Created attachment 459221 [details]
Patch for landing
Comment 9 EWS 2022-05-12 06:57:29 PDT 
Committed r294102 (250487@main): <https://commits.webkit.org/250487@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459221 [details].
Comment 10 Radar WebKit Bug Importer 2022-05-12 06:58:13 PDT 
<rdar://problem/93171741>