Bug 240224 - Create a stopped CacheStorageConnection for workers in case of detached documents
Summary: Create a stopped CacheStorageConnection for workers in case of detached docum...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-08 23:43 PDT by youenn fablet
Modified: 2022-05-10 03:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.22 KB, patch)
2022-05-08 23:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (6.23 KB, patch)
2022-05-10 01:21 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-05-08 23:43:10 PDT 
Create a stopped CacheStorageConnection for workers in case of detached documents
Comment 1 youenn fablet 2022-05-08 23:43:28 PDT 
<rdar://problem/92853663>
Comment 2 youenn fablet 2022-05-08 23:47:18 PDT 
Created attachment 459029 [details]
Patch
Comment 3 Chris Dumez 2022-05-09 07:13:28 PDT 
Comment on attachment 459029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459029&action=review

> Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp:117
> +class StoppedCacheStorageConnection : public CacheStorageConnection {

should be marked as final.
Comment 4 youenn fablet 2022-05-10 01:21:24 PDT 
Created attachment 459101 [details]
Patch for landing
Comment 5 EWS 2022-05-10 03:15:05 PDT 
Committed r294006 (250442@main): <https://commits.webkit.org/250442@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459101 [details].