Bug 240203 - [macOS] REGRESSION (r293825): Find highlight snapshots are incorrectly scaled
Summary: [macOS] REGRESSION (r293825): Find highlight snapshots are incorrectly scaled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-07 01:07 PDT by Said Abou-Hallawa
Modified: 2022-05-08 23:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.40 KB, patch)
2022-05-07 01:28 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (5.54 KB, patch)
2022-05-08 19:44 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-05-07 01:07:15 PDT 
takeSnapshots() depends on the snapshot ImageBuffer::resolutionScale() to set the size of the TextIndicatorData image. r293825 scaled the size of the ImageBuffer before creation and moved the scaling to the GraphicsContext. So we have correct scaled pixels but the resolutionScale is 1. So we get enlarged incorrect image.
Comment 1 Said Abou-Hallawa 2022-05-07 01:07:41 PDT 
rdar://92892014
Comment 2 Said Abou-Hallawa 2022-05-07 01:28:25 PDT 
Created attachment 458994 [details]
Patch
Comment 3 Said Abou-Hallawa 2022-05-08 19:44:08 PDT 
Created attachment 459020 [details]
Patch
Comment 4 EWS 2022-05-08 23:29:46 PDT 
Committed r293968 (250406@main): <https://commits.webkit.org/250406@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459020 [details].