Bug 240189 – Remove the abandoned NeedsAdobeFrameReloadingQuirk preference

• Status: NEW
• Component: WebKit Misc.

[Brent Fulgham]

Remove the NeedsAdobeFrameReloadingQuirk preference which is an internal-only setting that is no longer used in any WebKit code or testing.

[Brent Fulgham]

Created attachment 458977 [details]
Patch

[Brent Fulgham]

This is still used in one place, so not ready to remove this yet.

[Brent Fulgham]

*** Bug 239629 has been marked as a duplicate of this bug. ***

[Radar WebKit Bug Importer]

<rdar://problem/93270432>

[Tim Nguyen (:ntim)]

The only usage seems to be at: https://searchfox.org/wubkat/rev/bfe2441d9e38a24d34f9bf9a8de6a19b07dd20a6/Source/WebCore/html/HTMLFrameElementBase.cpp#176-180

Karl do you know if this is needed?

[Karl Dubost]

In https://github.com/WebKit/WebKit/blob/813f05167ea5885831eb6e2dd7797685bce21fbc/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml#L3987

It says:

> FIXME: This quirk is needed because of Radar 4674537 and 5211271

These bugs were from 2006 and 2007. I doubt they are relevant now. 

Let's track the initial commits for this
https://github.com/search?q=repo%3AWebKit%2FWebKit+NeedsAdobeFrameReloadingQuirk&type=commits

The check was applied for very old versions of Adobe product family Version 8 and less 
https://github.com/WebKit/WebKit/commit/5b1db51fac46e84bda37a1de4e0b3b1229e5d4f2

Most of these are not supported by Adobe anymore.
https://helpx.adobe.com/support/programs/eol-matrix.html

Adobe has also mostly switched to an online web app business model. 


I think we can remove it.

[Karl Dubost]

Brent, when you said:

> This is still used in one place, so not ready to remove this yet.


What did you have in mind?
Used as in the WebKit code, or as used in one product out there?

[Brent Fulgham]

(In reply to Karl Dubost from comment #7)
> Brent, when you said:
> 
> > This is still used in one place, so not ready to remove this yet.
> 
> 
> What did you have in mind?
> Used as in the WebKit code, or as used in one product out there?

It’s used by one of the Adobe installers on macOS. I’m not sure how long it’s been since they stopped using this code oath.

If it predates the 32-bit deprecation, maybe we can get rid of it.

[Karl Dubost]

January 2018  was the date for the deprecation 
Let's remove it.

[Ahmad Saleem]

Removed in Blink in 2013 here: https://src.chromium.org/viewvc/blink?view=revision&revision=147891