Bug 240180 - [macOS] HTTP traffic is not filtered in the parental controls filter
Summary: [macOS] HTTP traffic is not filtered in the parental controls filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-06 12:46 PDT by Per Arne Vollan
Modified: 2022-05-09 14:19 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2022-05-06 12:50 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.85 KB, patch)
2022-05-09 09:44 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.85 KB, patch)
2022-05-09 10:02 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-05-06 12:46:46 PDT 
Traditionally, we have not filtered HTTP in the parental controls filter on macOS, since other parts of the system has taken care of this. This appears to have changed now, and WebKit should also filter HTTP in addition to HTTPS.
Comment 1 Radar WebKit Bug Importer 2022-05-06 12:47:05 PDT 
<rdar://problem/92875540>
Comment 2 Per Arne Vollan 2022-05-06 12:50:24 PDT 
Created attachment 458969 [details]
Patch
Comment 3 Geoffrey Garen 2022-05-06 14:07:27 PDT 
Comment on attachment 458969 [details]
Patch

r=me
Comment 4 Per Arne Vollan 2022-05-06 15:01:19 PDT 
Comment on attachment 458969 [details]
Patch

Thanks for reviewing!
Comment 5 EWS 2022-05-06 16:11:54 PDT 
Committed r293929 (250376@main): <https://commits.webkit.org/250376@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458969 [details].
Comment 6 Alexey Proskuryakov 2022-05-06 19:15:41 PDT 
Comment on attachment 458969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458969&action=review

> Source/WebCore/ChangeLog:10
> +        has taken care of this. This appears to have changed now, and WebKit should also filter HTTP in addition to HTTPS.

Has this changed in all OS versions that we will be shipping this code on, or only some of them?
Comment 7 Per Arne Vollan 2022-05-09 09:25:51 PDT 
(In reply to Alexey Proskuryakov from comment #6)
> Comment on attachment 458969 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458969&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        has taken care of this. This appears to have changed now, and WebKit should also filter HTTP in addition to HTTPS.
> 
> Has this changed in all OS versions that we will be shipping this code on,
> or only some of them?

That is a good point! It appears that it has only changed in the most recent public macOS version. I can look into creating an ENABLE macro for this.

Thanks for reviewing!
Comment 8 Per Arne Vollan 2022-05-09 09:44:16 PDT 
Reopening to attach new patch.
Comment 9 Per Arne Vollan 2022-05-09 09:44:17 PDT 
Created attachment 459052 [details]
Patch
Comment 10 Per Arne Vollan 2022-05-09 10:02:26 PDT 
Created attachment 459054 [details]
Patch
Comment 11 Per Arne Vollan 2022-05-09 12:55:15 PDT 
Comment on attachment 459054 [details]
Patch

Thanks for reviewing!
Comment 12 EWS 2022-05-09 14:19:11 PDT 
Committed r293990 (250427@main): <https://commits.webkit.org/250427@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459054 [details].