Bug 240178 – [macOS] Content filter blocking shield is not displayed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

Content filter blocking shield is not displayed on macOS for blocked URLs.

[Per Arne Vollan]

<rdar://91586177>

[Per Arne Vollan]

Created attachment 458966 [details]
Patch

[Geoffrey Garen]

Comment on attachment 458966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458966&action=review

r=me

> Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> +        auto unblocked = false;
> +        callOnMainThread([decisionHandler, unblocked] {
> +            decisionHandler(unblocked);
> +        });

Can unblocked be a local variable rather than a captured variable here?

[Per Arne Vollan]

(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 458966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458966&action=review
> 
> r=me
> 
> > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> > +        auto unblocked = false;
> > +        callOnMainThread([decisionHandler, unblocked] {
> > +            decisionHandler(unblocked);
> > +        });
> 
> Can unblocked be a local variable rather than a captured variable here?

Yes, that is a good point, will fix.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 458976 [details]
Patch

[EWS]

Committed r293931 (250378@main): <https://commits.webkit.org/250378@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458976 [details].