Bug 240178 - [macOS] Content filter blocking shield is not displayed
Summary: [macOS] Content filter blocking shield is not displayed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-06 11:34 PDT by Per Arne Vollan
Modified: 2022-05-06 17:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2022-05-06 11:46 PDT, Per Arne Vollan 		ggaren: review+
Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2022-05-06 15:11 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-05-06 11:34:38 PDT 
Content filter blocking shield is not displayed on macOS for blocked URLs.
Comment 1 Per Arne Vollan 2022-05-06 11:34:55 PDT 
<rdar://91586177>
Comment 2 Per Arne Vollan 2022-05-06 11:46:32 PDT 
Created attachment 458966 [details]
Patch
Comment 3 Geoffrey Garen 2022-05-06 14:09:52 PDT 
Comment on attachment 458966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458966&action=review

r=me

> Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> +        auto unblocked = false;
> +        callOnMainThread([decisionHandler, unblocked] {
> +            decisionHandler(unblocked);
> +        });

Can unblocked be a local variable rather than a captured variable here?
Comment 4 Per Arne Vollan 2022-05-06 15:02:25 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 458966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458966&action=review
> 
> r=me
> 
> > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> > +        auto unblocked = false;
> > +        callOnMainThread([decisionHandler, unblocked] {
> > +            decisionHandler(unblocked);
> > +        });
> 
> Can unblocked be a local variable rather than a captured variable here?

Yes, that is a good point, will fix.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2022-05-06 15:11:07 PDT 
Created attachment 458976 [details]
Patch
Comment 6 EWS 2022-05-06 17:02:58 PDT 
Committed r293931 (250378@main): <https://commits.webkit.org/250378@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458976 [details].