Bug 240162 - [Flatpak SDK] Update mold to version 1.2.1
Summary: [Flatpak SDK] Update mold to version 1.2.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-06 03:10 PDT by Adrian Perez
Modified: 2022-05-06 07:47 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-05-06 03:10:49 PDT
Version 1.2.1 was released a few days ago, with many improvements for LTO
support (and Clang's ThinLTO):

  https://github.com/rui314/mold/releases/tag/v1.2.1

Now --gdb-index is properly supported, and reading the release notes I've
learnt that one needs to pass -ggnu-pubnames to the compiler for the option
to actually do something (which we are not currently doing, follow-up patch
later on).
Comment 1 Adrian Perez 2022-05-06 06:46:34 PDT
Here there's some numbers for my build machine, making an initial
RelWithDebInfo build, removing bin/* and lib/*.so* from the build
directory and then measuring how much it takes for the build to
complete, in order to (mostly) measure link time:

Mold				LLD			
usr	sys	wall		usr	sys	wall	
							
45,94	1,64	48,77		56,86	79,31	46,27	
42,32	1,19	44,48		60,09	77,43	49,78	
45,69	1,33	48,19		56,30	74,35	46,04	
42,19	1,29	44,65		60,19	78,22	49,77	
45,54	1,73	48,52		56,56	79,41	46,33	
							
44,03	1,36	46,52		58,36	77,33	47,96	avg
							
				1,33x	56,75x	1,03x	diff

Something very interesting to note is that the wall time for both
linkers is quite similar, but LLD is taking considerably more user
and system time than Mold. Neither manage to bring CPU usage up
to 100% across all 64 cores in my build machine, which means the
bottleneck here is disk access.

On machines with higher I/O thoroughput (better bus, better drives,
RAID-0 arrangement, etc.), the faster the disk access gets, the
faster using Mold will be.
Comment 2 Adrian Perez 2022-05-06 06:48:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/542
Comment 3 EWS 2022-05-06 07:46:33 PDT
Committed r293887 (250345@main): <https://commits.webkit.org/250345@main>

Reviewed commits have been landed. Closing PR #542 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-05-06 07:47:12 PDT
<rdar://problem/92859456>