WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
240159
[WebGPU] Fix build on downlevel OSes in Apple's build system
https://bugs.webkit.org/show_bug.cgi?id=240159
Summary
[WebGPU] Fix build on downlevel OSes in Apple's build system
Myles C. Maxfield
Reported
2022-05-06 00:35:14 PDT
[WebGPU] Fix build on downlevel OSes in Apple's build system
Attachments
Patch
(13.80 KB, patch)
2022-05-06 00:38 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2022-05-06 00:38:10 PDT
Created
attachment 458938
[details]
Patch
Myles C. Maxfield
Comment 2
2022-05-06 00:38:13 PDT
<
rdar://problem/92524485
>
Myles C. Maxfield
Comment 3
2022-05-06 00:38:28 PDT
***
Bug 239923
has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 4
2022-05-06 08:39:29 PDT
Comment on
attachment 458938
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=458938&action=review
> Source/WebGPU/Configurations/Base.xcconfig:27 > +#include? "<DEVELOPER_DIR>/AppleInternal/XcodeConfig/PlatformSupport.xcconfig" > #include "SDKVariant.xcconfig" > +#include "WebKitTargetConditionals.xcconfig"
I see that for WebCore, these are in WebCore.xcconfig, not in Base.xcconfig. Is it possible to keep these projects similar, to reduce future confusion?
Myles C. Maxfield
Comment 5
2022-05-06 09:42:18 PDT
Comment on
attachment 458938
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=458938&action=review
>> Source/WebGPU/Configurations/Base.xcconfig:27 >> +#include "WebKitTargetConditionals.xcconfig" > > I see that for WebCore, these are in WebCore.xcconfig, not in Base.xcconfig. Is it possible to keep these projects similar, to reduce future confusion?
Oh, I was following the model of JavaScriptCore, which has them in JavaScriptCore.xcconfig.
Alexey Proskuryakov
Comment 6
2022-05-06 10:06:49 PDT
JSC does indeed have in Base.xcconfig. Ok then!
EWS
Comment 7
2022-05-06 17:50:08 PDT
Committed
r293937
(
250383@main
): <
https://commits.webkit.org/250383@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 458938
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug