Bug 240156 – Make the various shouldApplyContainment() functions member functions on RenderElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Make the various shouldApplyContainment() functions member functions on RenderElement

[Simon Fraser (smfr)]

Created attachment 458932 [details]
Patch

[alan]

Comment on attachment 458932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458932&action=review

> Source/WebCore/rendering/RenderElement.h:505
> +inline bool RenderElement::shouldApplyLayoutContainment() const
> +{
> +    return style().containsLayout() && (!isInline() || isAtomicInlineLevelBox()) && !isRubyText() && (!isTablePart() || isRenderBlockFlow());
> +}

at some point these could all be moved to RenderBlock (or maybe even RenderBlockFlow) since the current render tree has this built-in type information. super not important -and also LFC tree does not work like that either.

[Rob Buis]

IIRC somebody (Darin?) requested free functions during review, but I am fine with class methods.

[Simon Fraser (smfr)]

(In reply to Rob Buis from comment #3)
> IIRC somebody (Darin?) requested free functions during review, but I am fine
> with class methods.

I think it was me, but seeing how all the callers pass *this, I changed my mind :)

[EWS]

Committed r293900 (250358@main): <https://commits.webkit.org/250358@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458932 [details].

[Radar WebKit Bug Importer]

<rdar://problem/92867194>