Bug 240153 - Add support for Notification objects with custom data
Summary: Add support for Notification objects with custom data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-05 21:21 PDT by Ben Nham
Modified: 2022-05-11 10:59 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-05-05 21:21:53 PDT 
We should support supplying extra data to the Notification constructor and retrieving it later, as outlined here:

https://notifications.spec.whatwg.org/#dom-notification-data
Comment 1 Ben Nham 2022-05-05 21:22:55 PDT 
<rdar://92677257>
Comment 2 Ben Nham 2022-05-05 21:46:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/540
Comment 3 EWS 2022-05-06 13:26:55 PDT 
Committed r293921 (250368@main): <https://commits.webkit.org/250368@main>

Reviewed commits have been landed. Closing PR #540 and removing active labels.
Comment 4 youenn fablet 2022-05-10 06:15:01 PDT 
imported/w3c/web-platform-tests/notifications/idlharness.https.any.html probably needs a WK1 rebase.
Comment 5 Ben Nham 2022-05-11 10:59:51 PDT 
Committed r294061 (250465@trunk): <https://commits.webkit.org/250465@trunk>