Bug 240137 – Several tests fail because CFImageSourceCreateImageAtIndex premultiplies alpha with PNG files for iOS family devices

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[John Cunningham]

Several tests fail because CFImageSourceCreateImageAtIndex premultiplies alpha with PNG files for iOS family devices

[John Cunningham]

Created attachment 458910 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 458910 [details]
Patch

Does this allow us to mark some iOS tests as no longer failing?

[Alexey Proskuryakov]

Comment on attachment 458910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458910&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:79
> +#if HAVE(IMAGE_IO_CREATE_UNPREMULTIPLIED_PNG) && USE(APPLE_INTERNAL_SDK)

USE(APPLE_INTERNAL_SDK) seems wrong here, and should probably be omitted? We even redeclare the symbol for open source builds (and will need to add .tbd, but that can be done later).

[John Cunningham]

Created attachment 459198 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/93198134>

[Said Abou-Hallawa]

-- What is the impact of this change? Will it fix displaying some PNG images? Can you attach an image which shows the problem?

-- You said above that there are several tests which fail because we are not using kCGImageSourceCreateUnpremultipliedPNG. What are these tests? And why there is no change in the TestExpectation then?

-- Is there a perf impact because of this change?

[Simon Fraser (smfr)]

Comment on attachment 459198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459198&action=review

> Source/WTF/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=240137

There should be a radar here too, in particular so we can correlate it with internal layout tests.

> Source/WTF/wtf/PlatformHave.h:1170
> +#define HAVE_IMAGE_IO_CREATE_UNPREMULTIPLIED_PNG 1

Elsewhere we use HAVE_IMAGEIO_

[John Cunningham]

Created attachment 459390 [details]
“Patch

[John Cunningham]

Created attachment 459391 [details]
“Patch

[John Cunningham]

Created attachment 459392 [details]
Patch for landing

[John Cunningham]

Pull request: https://github.com/WebKit/WebKit/pull/902

[EWS]

Committed r294660 (250880@main): <https://commits.webkit.org/250880@main>

Reviewed commits have been landed. Closing PR #902 and removing active labels.