Bug 240132 - Avoid resolving style for elements that only inherit changes from parent
Summary: Avoid resolving style for elements that only inherit changes from parent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on: 240770
Blocks:
  Show dependency tree / graph
 
Reported: 2022-05-05 11:21 PDT by Antti Koivisto
Modified: 2022-05-21 23:24 PDT (History)
14 users (show)

See Also:

Attachments
Patch (17.14 KB, patch)
2022-05-05 11:23 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (27.13 KB, patch)
2022-05-07 04:26 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (27.13 KB, patch)
2022-05-07 04:28 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (27.10 KB, patch)
2022-05-07 05:14 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (27.63 KB, patch)
2022-05-07 06:59 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (27.63 KB, patch)
2022-05-07 22:57 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-05-05 11:21:10 PDT 
We may do unnecessary work in the subtree when an inherited property changes.
Comment 1 Antti Koivisto 2022-05-05 11:23:11 PDT 
Created attachment 458897 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-05-06 10:14:39 PDT 
<rdar://problem/92867346>
Comment 3 Antti Koivisto 2022-05-07 04:26:02 PDT 
Created attachment 458998 [details]
Patch
Comment 4 Antti Koivisto 2022-05-07 04:28:08 PDT 
Created attachment 458999 [details]
Patch
Comment 5 Antti Koivisto 2022-05-07 05:14:11 PDT 
Created attachment 459000 [details]
Patch
Comment 6 Antti Koivisto 2022-05-07 06:59:50 PDT 
Created attachment 459001 [details]
Patch
Comment 7 Sam Weinig 2022-05-07 10:50:58 PDT 
Comment on attachment 459001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459001&action=review

> Source/WebCore/ChangeLog:10
> +        is done by simply running the full style resolution for them sincluding selector matching and

typo: sincluding -> including

> Source/WebCore/ChangeLog:13
> +        In a common case nothing changes in descendants expect the inherited properties. This patch implements

typo. "In a common case" usually we say "In the common case".

> Source/WebCore/css/CSSProperties.json:96
> +        "Indicates that this CSS property can use fast-path inheritance mechanism.",

"Indicates that this CSS property can use fast-path inheritance mechanism.", -> "Indicates that this CSS property can use the fast-path inheritance mechanism.",
Comment 8 Antti Koivisto 2022-05-07 22:57:20 PDT 
Created attachment 459010 [details]
Patch for landing
Comment 9 EWS 2022-05-08 00:13:30 PDT 
Committed r293956 (250402@main): <https://commits.webkit.org/250402@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459010 [details].