Bug 240127 – Create reports for long process launch times

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

We have reports that it can take a long time to launch WebKit processes in some cases. This is the time it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens in order to help diagnose the issue.

[Per Arne Vollan]

Created attachment 458890 [details]
Patch

[Per Arne Vollan]

Created attachment 458891 [details]
Patch

[Per Arne Vollan]

Created attachment 458893 [details]
Patch

[Per Arne Vollan]

Created attachment 458900 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 458900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458900&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:190
> +    WallTime m_proccessStart;

Let's use MonotonicTime since WallTime can be changed by user's timezone change etc.

[Per Arne Vollan]

Created attachment 458908 [details]
Patch

[Per Arne Vollan]

(In reply to Yusuke Suzuki from comment #5)
> Comment on attachment 458900 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458900&action=review
> 
> > Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:190
> > +    WallTime m_proccessStart;
> 
> Let's use MonotonicTime since WallTime can be changed by user's timezone
> change etc.

Fixed.

Thanks for reviewing!

[Yusuke Suzuki]

Comment on attachment 458908 [details]
Patch

r=me

[Per Arne Vollan]

(In reply to Yusuke Suzuki from comment #8)
> Comment on attachment 458908 [details]
> Patch
> 
> r=me

Thanks for reviewing!

[EWS]

Committed r293893 (250351@main): <https://commits.webkit.org/250351@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458908 [details].

[Radar WebKit Bug Importer]

<rdar://problem/92862824>

[Alexey Proskuryakov]

Comment on attachment 458908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458908&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111
> +    m_proccessStart = MonotonicTime::now();

typo: proccess

[Per Arne Vollan]

(In reply to Alexey Proskuryakov from comment #12)
> Comment on attachment 458908 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458908&action=review
> 
> > Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111
> > +    m_proccessStart = MonotonicTime::now();
> 
> typo: proccess

Good catch, will fix.

Thanks for reviewing!

[Per Arne Vollan]

Reopening to attach new patch.

[Per Arne Vollan]

Created attachment 459051 [details]
Patch

[EWS]

Committed r293979 (250417@main): <https://commits.webkit.org/250417@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459051 [details].