Bug 240127 - Create reports for long process launch times
Summary: Create reports for long process launch times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-05 10:46 PDT by Per Arne Vollan
Modified: 2022-05-09 12:25 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.55 KB, patch)
2022-05-05 10:53 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2022-05-05 10:56 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2022-05-05 10:57 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2022-05-05 11:37 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2022-05-05 13:24 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.34 KB, patch)
2022-05-09 09:08 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-05-05 10:46:35 PDT 
We have reports that it can take a long time to launch WebKit processes in some cases. This is the time it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens in order to help diagnose the issue.
Comment 1 Per Arne Vollan 2022-05-05 10:53:30 PDT 
Created attachment 458890 [details]
Patch
Comment 2 Per Arne Vollan 2022-05-05 10:56:12 PDT 
Created attachment 458891 [details]
Patch
Comment 3 Per Arne Vollan 2022-05-05 10:57:17 PDT 
Created attachment 458893 [details]
Patch
Comment 4 Per Arne Vollan 2022-05-05 11:37:15 PDT 
Created attachment 458900 [details]
Patch
Comment 5 Yusuke Suzuki 2022-05-05 11:42:26 PDT 
Comment on attachment 458900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458900&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:190
> +    WallTime m_proccessStart;

Let's use MonotonicTime since WallTime can be changed by user's timezone change etc.
Comment 6 Per Arne Vollan 2022-05-05 13:24:17 PDT 
Created attachment 458908 [details]
Patch
Comment 7 Per Arne Vollan 2022-05-05 13:25:10 PDT 
(In reply to Yusuke Suzuki from comment #5)
> Comment on attachment 458900 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458900&action=review
> 
> > Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:190
> > +    WallTime m_proccessStart;
> 
> Let's use MonotonicTime since WallTime can be changed by user's timezone
> change etc.

Fixed.

Thanks for reviewing!
Comment 8 Yusuke Suzuki 2022-05-05 16:13:32 PDT 
Comment on attachment 458908 [details]
Patch

r=me
Comment 9 Per Arne Vollan 2022-05-06 07:45:59 PDT 
(In reply to Yusuke Suzuki from comment #8)
> Comment on attachment 458908 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 10 EWS 2022-05-06 08:59:50 PDT 
Committed r293893 (250351@main): <https://commits.webkit.org/250351@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458908 [details].
Comment 11 Radar WebKit Bug Importer 2022-05-06 09:00:19 PDT 
<rdar://problem/92862824>
Comment 12 Alexey Proskuryakov 2022-05-06 19:24:47 PDT 
Comment on attachment 458908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458908&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111
> +    m_proccessStart = MonotonicTime::now();

typo: proccess
Comment 13 Per Arne Vollan 2022-05-09 09:05:06 PDT 
(In reply to Alexey Proskuryakov from comment #12)
> Comment on attachment 458908 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458908&action=review
> 
> > Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111
> > +    m_proccessStart = MonotonicTime::now();
> 
> typo: proccess

Good catch, will fix.

Thanks for reviewing!
Comment 14 Per Arne Vollan 2022-05-09 09:08:43 PDT 
Reopening to attach new patch.
Comment 15 Per Arne Vollan 2022-05-09 09:08:45 PDT 
Created attachment 459051 [details]
Patch
Comment 16 EWS 2022-05-09 09:53:26 PDT 
Committed r293979 (250417@main): <https://commits.webkit.org/250417@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459051 [details].