Bug 24012 – Convert inline-ignored-on-legend to text-only test

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dimitri Glazkov (Google)]

There's no reason for this test to be not text-only. So I am converting it to text-only. Plus some explanation.

[Dimitri Glazkov (Google)]

Created attachment 27768 [details]
Convert inline-ignored-on-legend to text-only test, v1.

 LayoutTests/ChangeLog                              |   13 +++++++++++++
 .../forms/inline-ignored-on-legend-expected.txt    |    3 +++
 .../fast/forms/inline-ignored-on-legend.html       |   11 ++++++++++-
 .../inline-ignored-on-legend-expected.checksum     |    1 -
 .../forms/inline-ignored-on-legend-expected.png    |  Bin 13718 -> 0 bytes
 .../forms/inline-ignored-on-legend-expected.txt    |   16 ----------------
 6 files changed, 26 insertions(+), 18 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 27768 [details]
Convert inline-ignored-on-legend to text-only test, v1.

Looks fine.  MIght as well add a newline at the end of hte file while you're there.

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/41069.

[Dave Hyatt]

Please back this change out.  A text only test is not helpful here, since you need to see the pixel rendering to know how the legend ended up getting treated.

[Dimitri Glazkov (Google)]

Ok, I am going to try to spin again.

Basically, we don't really need the pixel rendering -- all we need is making sure that legend is a block element. That's fairly easy to accomplish:

<div>First Line</div>Second Line vs. <span>First Line</span>Second Line

These will render differently even in text-only. Even in our existing test case, there's an extra line break in the expected result. I can "accentuate" it in the test to make it clear to the observer as to what the successful output is.

[Dimitri Glazkov (Google)]

Created attachment 27793 [details]
Clarify objective of the test and clean up, v1

 LayoutTests/ChangeLog                              |   10 ++++++++++
 .../forms/inline-ignored-on-legend-expected.txt    |    5 +++--
 .../fast/forms/inline-ignored-on-legend.html       |   18 +++++++-----------
 3 files changed, 20 insertions(+), 13 deletions(-)

[Dimitri Glazkov (Google)]

Comment on attachment 27793 [details]
Clarify objective of the test and clean up, v1

Here's a simplified, clarified test case, which works in text-only mode.

[Dave Hyatt]

Comment on attachment 27793 [details]
Clarify objective of the test and clean up, v1

Yeah better.

[Dimitri Glazkov (Google)]

Fix/clean up landed as http://trac.webkit.org/changeset/41079.