Bug 24012 - Convert inline-ignored-on-legend to text-only test
Summary: Convert inline-ignored-on-legend to text-only test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-18 15:53 PST by Dimitri Glazkov (Google)
Modified: 2009-02-19 11:22 PST (History)
0 users

See Also:


Attachments
Convert inline-ignored-on-legend to text-only test, v1. (3.98 KB, patch)
2009-02-18 15:57 PST, Dimitri Glazkov (Google)
eric: review+
Details | Formatted Diff | Diff
Clarify objective of the test and clean up, v1 (2.34 KB, patch)
2009-02-19 09:50 PST, Dimitri Glazkov (Google)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-18 15:53:47 PST
There's no reason for this test to be not text-only. So I am converting it to text-only. Plus some explanation.
Comment 1 Dimitri Glazkov (Google) 2009-02-18 15:57:38 PST
Created attachment 27768 [details]
Convert inline-ignored-on-legend to text-only test, v1.

 LayoutTests/ChangeLog                              |   13 +++++++++++++
 .../forms/inline-ignored-on-legend-expected.txt    |    3 +++
 .../fast/forms/inline-ignored-on-legend.html       |   11 ++++++++++-
 .../inline-ignored-on-legend-expected.checksum     |    1 -
 .../forms/inline-ignored-on-legend-expected.png    |  Bin 13718 -> 0 bytes
 .../forms/inline-ignored-on-legend-expected.txt    |   16 ----------------
 6 files changed, 26 insertions(+), 18 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-18 16:03:35 PST
Comment on attachment 27768 [details]
Convert inline-ignored-on-legend to text-only test, v1.

Looks fine.  MIght as well add a newline at the end of hte file while you're there.
Comment 3 Dimitri Glazkov (Google) 2009-02-18 16:16:05 PST
Landed as http://trac.webkit.org/changeset/41069.
Comment 4 Dave Hyatt 2009-02-18 16:35:42 PST
Please back this change out.  A text only test is not helpful here, since you need to see the pixel rendering to know how the legend ended up getting treated.
Comment 5 Dimitri Glazkov (Google) 2009-02-18 20:00:41 PST
Ok, I am going to try to spin again.

Basically, we don't really need the pixel rendering -- all we need is making sure that legend is a block element. That's fairly easy to accomplish:

<div>First Line</div>Second Line vs. <span>First Line</span>Second Line

These will render differently even in text-only. Even in our existing test case, there's an extra line break in the expected result. I can "accentuate" it in the test to make it clear to the observer as to what the successful output is.
Comment 6 Dimitri Glazkov (Google) 2009-02-19 09:50:37 PST
Created attachment 27793 [details]
Clarify objective of the test and clean up, v1

 LayoutTests/ChangeLog                              |   10 ++++++++++
 .../forms/inline-ignored-on-legend-expected.txt    |    5 +++--
 .../fast/forms/inline-ignored-on-legend.html       |   18 +++++++-----------
 3 files changed, 20 insertions(+), 13 deletions(-)
Comment 7 Dimitri Glazkov (Google) 2009-02-19 09:51:49 PST
Comment on attachment 27793 [details]
Clarify objective of the test and clean up, v1

Here's a simplified, clarified test case, which works in text-only mode.
Comment 8 Dave Hyatt 2009-02-19 11:15:39 PST
Comment on attachment 27793 [details]
Clarify objective of the test and clean up, v1

Yeah better.
Comment 9 Dimitri Glazkov (Google) 2009-02-19 11:22:44 PST
Fix/clean up landed as http://trac.webkit.org/changeset/41079.