Bug 240109 - Implement :modal CSS pseudo-class
Summary: Implement :modal CSS pseudo-class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: dialog-element
  Show dependency tree / graph
 
Reported: 2022-05-04 22:30 PDT by Tim Nguyen (:ntim)
Modified: 2022-05-09 15:34 PDT (History)
13 users (show)

See Also:

Attachments
Patch (19.36 KB, patch)
2022-05-09 11:33 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (19.43 KB, patch)
2022-05-09 11:34 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (19.43 KB, patch)
2022-05-09 11:37 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (19.43 KB, patch)
2022-05-09 11:40 PDT, Tim Nguyen (:ntim) 		simon.fraser: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.50 KB, patch)
2022-05-09 12:09 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-05-04 22:30:12 PDT 
It's just a matter of exposing the internal :-internal-modal-dialog pseudo-class to the wild.

https://github.com/w3c/csswg-drafts/issues/6965#issuecomment-1118033655
Comment 1 Radar WebKit Bug Importer 2022-05-04 22:31:56 PDT 
<rdar://problem/92775435>
Comment 2 Tim Nguyen (:ntim) 2022-05-09 11:33:04 PDT 
Created attachment 459060 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2022-05-09 11:34:59 PDT 
Created attachment 459061 [details]
Patch
Comment 4 EWS Watchlist 2022-05-09 11:35:38 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Tim Nguyen (:ntim) 2022-05-09 11:37:35 PDT 
Created attachment 459062 [details]
Patch
Comment 6 Tim Nguyen (:ntim) 2022-05-09 11:40:07 PDT 
Created attachment 459063 [details]
Patch
Comment 7 Simon Fraser (smfr) 2022-05-09 12:00:08 PDT 
Comment on attachment 459063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459063&action=review

> Source/WebCore/html/HTMLDialogElement.cpp:169
> +    Style::PseudoClassChangeInvalidation styleInvalidation(*this, CSSSelector::PseudoClassModal, newValue);
> +    m_isModal = newValue;

Should this check if it has changed?
Comment 8 Tim Nguyen (:ntim) 2022-05-09 12:09:21 PDT 
Created attachment 459065 [details]
Patch
Comment 9 EWS 2022-05-09 13:38:28 PDT 
Committed r293987 (250424@main): <https://commits.webkit.org/250424@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459065 [details].