Bug 240102 - [JSC] Intl.NumberFormat lacks some validation for rounding-increment
Summary: [JSC] Intl.NumberFormat lacks some validation for rounding-increment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-04 17:39 PDT by Yusuke Suzuki
Modified: 2022-05-06 07:33 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-05-04 17:39:55 PDT 
[JSC] Intl.NumberFormat lacks some validation for rounding-increment
Comment 1 Yusuke Suzuki 2022-05-04 17:42:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/517
Comment 2 EWS 2022-05-04 19:22:21 PDT 
Committed r293813 (250286@main): <https://commits.webkit.org/250286@main>

Reviewed commits have been landed. Closing PR #517 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-04 19:23:13 PDT 
<rdar://problem/92768775>
Comment 4 Michael Catanzaro 2022-05-05 07:11:07 PDT 
It introduced failures when running with cloop:

Running stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: @intl-numberformat-rounding-increment-resolved-match-v3.js:39:35
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: forEach@[native code]
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: global code@intl-numberformat-rounding-increment-resolved-match-v3.js:38:32
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default

Running stress/intl-numberformat-rounding-increment-v3.js.default
stress/intl-numberformat-rounding-increment-v3.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-v3.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-v3.js.default: @intl-numberformat-rounding-increment-v3.js:52:26
stress/intl-numberformat-rounding-increment-v3.js.default: forEach@[native code]
stress/intl-numberformat-rounding-increment-v3.js.default: global code@intl-numberformat-rounding-increment-v3.js:51:32
stress/intl-numberformat-rounding-increment-v3.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-v3.js.default

stress/intl-numberformat-rounding-increment-value.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-value.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-value.js.default: global code@intl-numberformat-rounding-increment-value.js:7:31
stress/intl-numberformat-rounding-increment-value.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-value.js.default

I suppose I'd better print the values that are being compared to see what's up.
Comment 5 Yusuke Suzuki 2022-05-05 12:45:11 PDT 
Committed r293858 (250323@trunk): <https://commits.webkit.org/250323@trunk>
Comment 6 Angelos Oikonomopoulos 2022-05-05 13:50:48 PDT 
See also https://bugs.webkit.org/show_bug.cgi?id=240138.
Comment 7 Michael Catanzaro 2022-05-06 07:33:43 PDT 
(In reply to Yusuke Suzuki from comment #5)
> Committed r293858 (250323@trunk): <https://commits.webkit.org/250323@trunk>

Thanks, that fixed it.