Bug 240099 - REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist
Summary: REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-04 17:21 PDT by Tim Horton
Modified: 2022-05-05 14:53 PDT (History)
4 users (show)

See Also:

Attachments
patch (4.73 KB, patch)
2022-05-04 17:22 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-05-04 17:21:34 PDT 
REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist
Comment 1 Tim Horton 2022-05-04 17:21:46 PDT 
<rdar://92751323>
Comment 2 Tim Horton 2022-05-04 17:22:09 PDT 
Created attachment 458838 [details]
patch
Comment 3 EWS 2022-05-04 21:24:50 PDT 
Committed r293818 (250291@main): <https://commits.webkit.org/250291@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458838 [details].
Comment 4 Alexey Proskuryakov 2022-05-04 22:22:45 PDT 
Comment on attachment 458838 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458838&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134
> +			outputPaths = (

No outputPaths???
Comment 5 Tim Horton 2022-05-04 22:43:10 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 458838 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458838&action=review
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134
> > +			outputPaths = (
> 
> No outputPaths???

Hmm, a bit odd. I was following the one a few steps down called "Copy Daemon Plists", which also doesn't have outputPaths... I guess they're both wrong?
Comment 6 Elliott Williams 2022-05-05 08:53:06 PDT 
(In reply to Tim Horton from comment #5)
> (In reply to Alexey Proskuryakov from comment #4)
> > Comment on attachment 458838 [details]
> > patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=458838&action=review
> > 
> > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134
> > > +			outputPaths = (
> > 
> > No outputPaths???
> 
> Hmm, a bit odd. I was following the one a few steps down called "Copy Daemon
> Plists", which also doesn't have outputPaths... I guess they're both wrong?

It's not really a problem here, since I'm assuming there aren't other tasks in the build which take these /System/Library/FeatureFlags/* paths as inputs.
Comment 7 Alexey Proskuryakov 2022-05-05 09:51:42 PDT 
Does this make the script run unnecessarily during incremental builds?
Comment 8 Elliott Williams 2022-05-05 14:53:55 PDT 
(In reply to Alexey Proskuryakov from comment #7)
> Does this make the script run unnecessarily during incremental builds?

You're right, it does! That does seem like a meaningful downside :(