Bug 24006 - The option-mouseevents layout test should not depend on list box sizes.
Summary: The option-mouseevents layout test should not depend on list box sizes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-18 11:16 PST by Marc-André Decoste
Modified: 2009-03-11 10:58 PDT (History)
4 users (show)

See Also:


Attachments
Change Layout test to not depend on list box sizes (7.39 KB, patch)
2009-02-18 11:34 PST, Marc-André Decoste
no flags Details | Formatted Diff | Diff
A proposed modification for the layout test (7.39 KB, patch)
2009-03-04 12:01 PST, Marc-André Decoste
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Decoste 2009-02-18 11:16:28 PST
As suggested by comments in bug https://bugs.webkit.org/show_bug.cgi?id=3248, I create a new bug to track the fact that the Layout Test written for this bug, which is to test the notification of mouse events on option elements within a list box select element, depends on the size of the list boxes, which can be different based on the usage of WebKit in products other than Safari, and could even evolve within Safari at one point.
Comment 1 Marc-André Decoste 2009-02-18 11:34:22 PST
Created attachment 27759 [details]
Change Layout test to not depend on list box sizes

Modifications to the LayoutTest that has been created to validate the fix
of bug: https://bugs.webkit.org/show_bug.cgi?id=3248.
Comment 2 Alexey Proskuryakov 2009-02-18 11:41:24 PST
Comment on attachment 27759 [details]
Change Layout test to not depend on list box sizes

Someone else should review this - I don't know if it's ok for list boxes' sizes to ever change.
Comment 3 Marc-André Decoste 2009-03-04 11:18:16 PST
Ping? Anybody else could look at this?

Comment 4 Marc-André Decoste 2009-03-04 12:01:39 PST
Created attachment 28278 [details]
A proposed modification for the layout test

Resubmitting patch to remove the review flag...
Comment 5 Eric Seidel (no email) 2009-03-04 12:40:53 PST
Comment on attachment 28278 [details]
A proposed modification for the layout test

I don't really understand this change.  How are you changing the coordinate so that they are no longer dependent on list box size?
Comment 6 Marc-André Decoste 2009-03-04 12:46:13 PST
By fixing the position of all the list boxes in an absolute way, the size don't affect the position of subsequent list boxes.

Does this answer your question?

Comment 7 Eric Seidel (no email) 2009-03-04 12:52:19 PST
Comment on attachment 28278 [details]
A proposed modification for the layout test

Yes, now that I read it again, it makes sense.  Assuming this has left a reasonable amount of space between boxes so that all platforms can pass, this is r=me.
Comment 8 Pam Greene (IRC:pamg) 2009-03-11 10:58:21 PDT
Landed in r41589.