Bug 24006 – The option-mouseevents layout test should not depend on list box sizes.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Marc-André Decoste]

As suggested by comments in bug https://bugs.webkit.org/show_bug.cgi?id=3248, I create a new bug to track the fact that the Layout Test written for this bug, which is to test the notification of mouse events on option elements within a list box select element, depends on the size of the list boxes, which can be different based on the usage of WebKit in products other than Safari, and could even evolve within Safari at one point.

[Marc-André Decoste]

Created attachment 27759 [details]
Change Layout test to not depend on list box sizes

Modifications to the LayoutTest that has been created to validate the fix
of bug: https://bugs.webkit.org/show_bug.cgi?id=3248.

[Alexey Proskuryakov]

Comment on attachment 27759 [details]
Change Layout test to not depend on list box sizes

Someone else should review this - I don't know if it's ok for list boxes' sizes to ever change.

[Marc-André Decoste]

Ping? Anybody else could look at this?

[Marc-André Decoste]

Created attachment 28278 [details]
A proposed modification for the layout test

Resubmitting patch to remove the review flag...

[Eric Seidel (no email)]

Comment on attachment 28278 [details]
A proposed modification for the layout test

I don't really understand this change.  How are you changing the coordinate so that they are no longer dependent on list box size?

[Marc-André Decoste]

By fixing the position of all the list boxes in an absolute way, the size don't affect the position of subsequent list boxes.

Does this answer your question?

[Eric Seidel (no email)]

Comment on attachment 28278 [details]
A proposed modification for the layout test

Yes, now that I read it again, it makes sense.  Assuming this has left a reasonable amount of space between boxes so that all platforms can pass, this is r=me.

[Pam Greene (IRC:pamg)]

Landed in r41589.