Bug 240059 - CoreAudioCaptureSource::settingsDidChange should not reconfigure the audio unit if CoreAudioCaptureSource is not started
Summary: CoreAudioCaptureSource::settingsDidChange should not reconfigure the audio un...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-04 02:47 PDT by youenn fablet
Modified: 2022-05-09 07:07 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2022-05-04 02:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.52 KB, patch)
2022-05-09 02:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-05-04 02:47:56 PDT 
CoreAudioCaptureSource::settingsDidChange should not reconfigure the audio unit if CoreAudioCaptureSource is not started.
This might trigger debug ASSERT hasClients() in CoreAudioSharedUnit::setupAudioUnit in case the audio unit is running for only rendering audio.
Comment 1 youenn fablet 2022-05-04 02:51:23 PDT 
Created attachment 458783 [details]
Patch
Comment 2 youenn fablet 2022-05-09 02:36:51 PDT 
Created attachment 459038 [details]
Patch
Comment 3 EWS 2022-05-09 07:06:31 PDT 
Committed r293972 (250410@main): <https://commits.webkit.org/250410@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459038 [details].
Comment 4 Radar WebKit Bug Importer 2022-05-09 07:07:15 PDT 
<rdar://problem/92958589>