Conditional assertions are non-modal and already require a gesture to complete via a different mechanism. So if conditional mediation is available on the platform and requested, we should not require a gesture.
rdar://92137603
Created attachment 458756 [details] Patch
Comment on attachment 458756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458756&action=review r=me, but please check the cause of the debug failure. > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:326 > + requestContext.get().requestStyle = ASCredentialRequestStyleAutoFill; Nit: I'd prefer to check and do an early return if it does NOT respond to the selector, rather than this form. It's slightly easier to read and a little more concise. > Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:110 > + if (!data.processingUserGesture && !m_webPageProxy.websiteDataStore().authenticatorManager().isVirtual() && data.mediation != MediationRequirement::Conditional) Nit: It might be slightly more efficient to test the 'data.mediation' condition before retrieving the websiteDataStore->authenticator and calling its isVirtual method.
Created attachment 458758 [details] Patch for landing
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Created attachment 458812 [details] Patch for landing
Committed r293786 (250265@main): <https://commits.webkit.org/250265@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458812 [details].