Bug 240036 – Enable TextCheckingType::Correction on MacCatalyst.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Enable TextCheckingType::Correction on MacCatalyst.

[Megan Gardner]

Created attachment 458755 [details]
Patch

[Wenson Hsieh]

rdar://92691014

[Wenson Hsieh]

Comment on attachment 458755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458755&action=review

> Source/WebCore/editing/Editor.cpp:2886
> +            for (const auto& range : previousGrammarRanges) {
> +                if (range.location == resultLocation && range.length == resultLength) {
> +                    resultRangeIsAcceptableForReplacement = true;
> +                    break;
> +                }
> +            }

Nit - might be cleaner as

```
resultRangeIsAcceptableForReplacement = previousGrammarRanges.containsIf([&](auto& range) {
    return range.location == resultLocation && range.length == resultLength;
});
```

> Source/WebCore/editing/Editor.cpp:2909
> +                    previousGrammarRanges.append(CharacterRange(resultLocation + detail.range.location, detail.range.length));

Nit - I think we normally write this as `previousGrammarRanges.append({ resultLocation + detail.range.location, detail.range.length });`.

[Megan Gardner]

Created attachment 458772 [details]
Patch

[Megan Gardner]

Created attachment 458774 [details]
Patch for landing

[EWS]

Committed r293766 (250245@main): <https://commits.webkit.org/250245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458774 [details].