Right click using trackpad crashes Safari
Created attachment 458751 [details] Patch
Comment on attachment 458751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458751&action=review > Source/WebCore/page/EventHandler.cpp:572 > + if (!m_frame.selection().selection().isContentEditable() && (!result.targetNode() || !result.targetNode()->isTextNode())) nit: `!result.targetNode() || !result.targetNode()->isTextNode())` could be written as: `!is<Text>(result.targetNode())`
Nice! will fix that. Also looks like I might need to add #import <pal/spi/cocoa/RevealSPI.h> to make iOS sim happy.
Created attachment 458759 [details] Patch
Comment on attachment 458759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458759&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:179 > + [webView synchronouslyLoadTestPageNamed:@"empty"]; I think you meant to rename this to "emptyTable" too.
(In reply to Wenson Hsieh from comment #5) > Comment on attachment 458759 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458759&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:179 > > + [webView synchronouslyLoadTestPageNamed:@"empty"]; > > I think you meant to rename this to "emptyTable" too. I did indeed!
Created attachment 458796 [details] Patch
rdar://91786269
Comment on attachment 458796 [details] Patch API iOS test failures are unrelated.
Committed r293835 (250308@main): <https://commits.webkit.org/250308@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458796 [details].