Bug 239975 - [GitHub] git-webkit pr doesn't sort Xcode project files before uploading
Summary: [GitHub] git-webkit pr doesn't sort Xcode project files before uploading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 239082 254703
  Show dependency tree / graph
 
Reported: 2022-05-02 11:33 PDT by Chris Dumez
Modified: 2023-05-02 08:35 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-05-02 11:33:50 PDT 
git-webkit pr doesn't sort Xcode project files before uploading, which seems to be a regression compared to `webkit-patch upload`.
Comment 1 Radar WebKit Bug Importer 2022-05-09 11:34:13 PDT 
<rdar://problem/92976140>
Comment 2 Jonathan Bedard 2022-05-10 08:07:18 PDT 
There isn't a way for us to control this. PRs aren't patches, this is basically about how GitHub visualizes diffs between branches.
Comment 3 Chris Dumez 2022-05-10 08:27:04 PDT 
I think you misunderstood. If webkit-patch can sort Xcode files before uploading the patch, `git-webkit pr` can also sort Xcode files before uploading the PR.

If not, please provide a better explanation. We don't want Xcode project files to be unsorted in the WebKit repository. See Tools/Scripts/sort-Xcode-project-file (which we normally don't have to call manually because it get called before upload).
Comment 4 Jonathan Bedard 2022-05-10 08:35:40 PDT 
Talking with Chris, I misunderstood the ask here.

We do this sorting on disk prior to uploading the patch. We can do something similar with PRs.
Comment 5 Jonathan Bedard 2022-05-23 15:17:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/948
Comment 6 EWS 2022-05-24 08:39:28 PDT 
Committed r294748 (250916@main): <https://commits.webkit.org/250916@main>

Reviewed commits have been landed. Closing PR #948 and removing active labels.