Bug 239954 - using OptionSet iterator to find changes in GraphicsContextState::mergeChanges
Summary: using OptionSet iterator to find changes in GraphicsContextState::mergeChanges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-01 22:44 PDT by Cameron McCormack (:heycam)
Modified: 2022-05-08 00:00 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.70 KB, patch)
2022-05-07 15:39 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-05-01 22:44:57 PDT 
Instead of looping over all 15 Change bits, we can use the iterator on OptionSet to skip quickly to each set bit.
Comment 1 Radar WebKit Bug Importer 2022-05-01 22:45:04 PDT 
<rdar://problem/92593424>
Comment 2 Cameron McCormack (:heycam) 2022-05-07 15:39:15 PDT 
Created attachment 459004 [details]
Patch
Comment 3 Cameron McCormack (:heycam) 2022-05-07 15:39:58 PDT 
I preserved the clever formatting, but I'm happy to drop it.
Comment 4 Simon Fraser (smfr) 2022-05-07 20:49:17 PDT 
Landed with a typo fix: https://commits.webkit.org/250399@main