Bug 239947 - HTML Parser: Wrong column number in CR-LF line ending style (DOS EOL style) HTML files
Summary: HTML Parser: Wrong column number in CR-LF line ending style (DOS EOL style) H...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-01 14:06 PDT by Fujii Hironori
Modified: 2022-05-02 12:03 PDT (History)
2 users (show)

See Also:


Attachments
JSC stack (DOS EOL style) (101 bytes, text/html)
2022-05-01 14:06 PDT, Fujii Hironori
no flags Details
JSC stack (Unix EOL style) (99 bytes, text/html)
2022-05-01 14:07 PDT, Fujii Hironori
no flags Details
WIP patch (728 bytes, patch)
2022-05-01 16:46 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (5.32 KB, patch)
2022-05-01 19:44 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-05-01 14:06:38 PDT
Created attachment 458652 [details]
JSC stack (DOS EOL style)

HTML Parser: Wrong column number in CR-LF line ending style (DOS EOL style) HTML files

In this test case, WebKit reports the line number and column number as 2:31, but it should be 2:30.
Comment 1 Fujii Hironori 2022-05-01 14:07:09 PDT
Created attachment 458653 [details]
JSC stack (Unix EOL style)
Comment 2 Fujii Hironori 2022-05-01 14:08:43 PDT
The following tests can fail if the test files are checked out by Windows Git.

js/dom/line-column-numbers.html
js/dom/script-start-end-locations.html
js/dom/stack-trace.html
Comment 3 Fujii Hironori 2022-05-01 16:46:40 PDT
Created attachment 458654 [details]
WIP patch
Comment 4 Fujii Hironori 2022-05-01 19:44:20 PDT
Created attachment 458657 [details]
Patch
Comment 5 EWS 2022-05-02 12:02:58 PDT
Committed r293672 (250174@main): <https://commits.webkit.org/250174@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458657 [details].
Comment 6 Radar WebKit Bug Importer 2022-05-02 12:03:14 PDT
<rdar://problem/92623445>