Bug 239919 – Add option to JSC shell to wait for a USR2 signal before exiting to aid in collection of vmmaps

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Justin Michaud]

Add option to JSC shell to wait for a USR2 signal before exiting to aid in collection of vmmaps

[Justin Michaud]

Created attachment 458620 [details]
Patch

[Justin Michaud]

Comment on attachment 458620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458620&action=review

> Source/WTF/wtf/threads/Signals.h:66
> +    case Signal::Usr: return std::make_tuple(SIGUSR2, std::nullopt);

Either I fixed a happy little bug, or I am about to feel the wrath of some deep horrible bug that this works around

[Yusuke Suzuki]

Comment on attachment 458620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458620&action=review

r=me with comments.

> Source/JavaScriptCore/jsc.cpp:3041
> +    Lock waitToExitLock;
> +    Condition waitToExitCondition;
> +    bool mustWaitToExit = true;
> +

You can use WTF::BinarySemaphore instead.

> Source/JavaScriptCore/jsc.cpp:3049
> +            {
> +                Locker locker { waitToExitLock };
> +                mustWaitToExit = false;
> +                waitToExitCondition.notifyAll();
> +            }

Ditto.

> Source/JavaScriptCore/jsc.cpp:3078
> +        {
> +            Locker locker { waitToExitLock };
> +            while (mustWaitToExit)
> +                waitToExitCondition.wait(waitToExitLock);
> +        }
> +

Ditto.

>> Source/WTF/wtf/threads/Signals.h:66
>> +    case Signal::Usr: return std::make_tuple(SIGUSR2, std::nullopt);
> 
> Either I fixed a happy little bug, or I am about to feel the wrath of some deep horrible bug that this works around

Currently, Signal::Usr is not used. So yeah, it is a bug, but it will not affect on the existing code :)

[Justin Michaud]

Created attachment 458622 [details]
Patch

[Justin Michaud]

I'm going to land once EWS finishes.

[Justin Michaud]

Created attachment 458627 [details]
Patch

[EWS]

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

[Justin Michaud]

Created attachment 458705 [details]
Patch

[EWS]

Committed r293688 (250186@main): <https://commits.webkit.org/250186@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458705 [details].

[Radar WebKit Bug Importer]

<rdar://problem/92637189>