Bug 239914 - The isYahooMail quirk is specific to PLATFORM(IOS_FAMILY)
Summary: The isYahooMail quirk is specific to PLATFORM(IOS_FAMILY)
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Keywords: InRadar
Depends on:
Reported: 2022-04-29 15:16 PDT by Don Olmstead
Modified: 2022-04-30 13:55 PDT (History)
6 users (show)

See Also:

Patch (1.38 KB, patch)
2022-04-29 15:22 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-04-29 15:16:17 PDT
Found because of an unused function warning for isYahooMail.
Comment 1 Don Olmstead 2022-04-29 15:22:34 PDT
Created attachment 458612 [details]
Comment 2 EWS 2022-04-29 20:38:29 PDT
Committed r293641 (250145@main): <https://commits.webkit.org/250145@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458612 [details].
Comment 3 Radar WebKit Bug Importer 2022-04-29 20:39:14 PDT
Comment 4 Darin Adler 2022-04-30 13:55:21 PDT
Comment on attachment 458612 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=458612&action=review

> Source/WebCore/ChangeLog:10
> +        The isYahooMail check is incorrectly guarded by ENABLE(PUBLIC_SUFFIX_LIST) when the only
> +        using this function is guarded by ENABLE(IOS_TOUCH_EVENTS) and PLATFORM(IOS_FAMILY). Use
> +        PLATFORM(IOS_FAMILY) since ENABLE(IOS_TOUCH_EVENTS) implies that anyways.

I suppose this is a losing battle at this point, but I’ve tried to always use something more specific than the PLATFORM macro whenever possible. So in this case I would have used ENABLE(IOS_TOUCH_EVENTS).