Bug 239910 - [cssom] Some logical longhands still not enumerated in the computed style
Summary: [cssom] Some logical longhands still not enumerated in the computed style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-29 13:43 PDT by Oriol Brufau
Modified: 2022-05-02 11:07 PDT (History)
9 users (show)

See Also:


Attachments
Patch (27.48 KB, patch)
2022-04-29 14:17 PDT, Oriol Brufau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2022-04-29 13:43:41 PDT
Bug 210695 added support for enumerating most logical longhands in the computed style.
But as the commit message acknowledged, 

> Using the specification->category for this seems a bit hacky

Indeed, not all logical properties are defined in the css-logical spec.
For example, css-scroll-snap defines some of them.

This causes problems:

 - overscroll-behavior-{block,inline} are not enumerated
 - scroll-margin-block-{end,start} are not enumerated
 - scroll-margin-block is enumerated (since its longhands are not)
 - scroll-margin-inline-{end,start} are not enumerated
 - scroll-margin-inline is enumerated (since its longhands are not)
 - scroll-padding-block-{end,start} are not enumerated
 - scroll-padding-block is enumerated (since its longhands are not)
 - scroll-padding-inline-{end,start} are not enumerated
 - scroll-padding-inline is enumerated (since its longhands are not)

Rather than checking the spec, the code should check "logical-property-group".
Comment 1 Oriol Brufau 2022-04-29 14:17:52 PDT
Created attachment 458608 [details]
Patch
Comment 2 EWS 2022-05-02 11:06:13 PDT
Committed r293670 (250172@main): <https://commits.webkit.org/250172@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458608 [details].
Comment 3 Radar WebKit Bug Importer 2022-05-02 11:07:16 PDT
<rdar://problem/92620060>