Bug 239872 - Web Inspector: Regression(r267038) Import a timeline does not render the timeline, only lists the events
Summary: Web Inspector: Regression(r267038) Import a timeline does not render the time...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
Keywords: InRadar
Depends on:
Reported: 2022-04-28 14:30 PDT by Patrick Angle
Modified: 2022-04-29 15:33 PDT (History)
4 users (show)

See Also:

Patch v1.0 (4.99 KB, patch)
2022-04-28 18:16 PDT, Patrick Angle
no flags Details | Formatted Diff | Diff
Patch v1.1 (4.16 KB, patch)
2022-04-29 13:45 PDT, Patrick Angle
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2022-04-28 14:30:01 PDT
Comment 1 Patrick Angle 2022-04-28 18:16:46 PDT
Created attachment 458560 [details]
Patch v1.0
Comment 2 Devin Rousso 2022-04-29 12:14:55 PDT
Comment on attachment 458560 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=458560&action=review

r=me, nice fix =D

> Source/WebInspectorUI/ChangeLog:18
> +        The second issue is that when importing a timeline, we should ignore the current capturing state when setting
> +        the current, start, and end times, otherwise not all the values will be commited since most likely no recording
> +        is in progress at the same time a recording is being imported.

Along these lines, i feel like we should always ignore the current capturing state.  We don't want an imported recording to suddenly start showing new data because we started another recording.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:127
> +            this._updateTimes(startTime, endTime, endTime, {fromImport: true});

NIT: do we actually need a parameter, or can we just use `this._recording.imported` instead at each usage?
Comment 3 Patrick Angle 2022-04-29 13:45:50 PDT
Created attachment 458606 [details]
Patch v1.1
Comment 4 EWS 2022-04-29 14:51:30 PDT
Committed r293631 (250137@main): <https://commits.webkit.org/250137@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458606 [details].