Bug 239851 - Merge-queue error message about missing user permissions from contributors.json should indicate how to fix it
Summary: Merge-queue error message about missing user permissions from contributors.js...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-28 08:44 PDT by Aakash Jain
Modified: 2022-04-28 09:22 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-04-28 08:44:08 PDT 
Merge-queue error message about missing user permissions from contributors.json should indicate how to fix it.

Currently it just posts an error like: "@xyz does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.". This isn't very clear for the people who indeed have that permission as per contributors.json, but who haven't added their GitHub username to contributors.json.

The error message should clearly indicate how to fix it (which is to add github username to contributors.json).
Comment 1 Aakash Jain 2022-04-28 08:46:29 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/425
Comment 2 EWS 2022-04-28 09:21:02 PDT 
Committed r293573 (250087@main): <https://commits.webkit.org/250087@main>

Reviewed commits have been landed. Closing PR #425 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-04-28 09:22:14 PDT 
<rdar://problem/92467180>