Bug 239846 – Register shared workers as service worker clients

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Register shared workers as service worker clients

[youenn fablet]

Created attachment 458518 [details]
Patch

[youenn fablet]

Created attachment 458522 [details]
Patch

[Chris Dumez]

Comment on attachment 458522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458522&action=review

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:52
> +    WEBCORE_EXPORT static bool isEmpty();

This function name is super confusing. What does it mean for a SharedWorkerProxy to be empty?
I'd suggest something like hasInstances() but I'd be open to suggestions. I don't think we should land "isEmpty()" though.

[youenn fablet]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 458522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458522&action=review
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:52
> > +    WEBCORE_EXPORT static bool isEmpty();
> 
> This function name is super confusing. What does it mean for a
> SharedWorkerProxy to be empty?
> I'd suggest something like hasInstances() but I'd be open to suggestions. I
> don't think we should land "isEmpty()" though.

Agreed hasInstances is better

[youenn fablet]

Created attachment 458678 [details]
Patch

[EWS]

Committed r293665 (250169@main): <https://commits.webkit.org/250169@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458678 [details].

[Radar WebKit Bug Importer]

<rdar://problem/92612581>