Bug 239846 - Register shared workers as service worker clients
Summary: Register shared workers as service worker clients
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-28 05:17 PDT by youenn fablet
Modified: 2022-05-02 09:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2022-04-28 05:21 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.13 KB, patch)
2022-04-28 05:48 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.12 KB, patch)
2022-05-02 07:11 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-04-28 05:17:08 PDT 
Register shared workers as service worker clients
Comment 1 youenn fablet 2022-04-28 05:21:48 PDT 
Created attachment 458518 [details]
Patch
Comment 2 youenn fablet 2022-04-28 05:48:12 PDT 
Created attachment 458522 [details]
Patch
Comment 3 Chris Dumez 2022-04-28 10:56:08 PDT 
Comment on attachment 458522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458522&action=review

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:52
> +    WEBCORE_EXPORT static bool isEmpty();

This function name is super confusing. What does it mean for a SharedWorkerProxy to be empty?
I'd suggest something like hasInstances() but I'd be open to suggestions. I don't think we should land "isEmpty()" though.
Comment 4 youenn fablet 2022-04-28 23:34:28 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 458522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458522&action=review
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:52
> > +    WEBCORE_EXPORT static bool isEmpty();
> 
> This function name is super confusing. What does it mean for a
> SharedWorkerProxy to be empty?
> I'd suggest something like hasInstances() but I'd be open to suggestions. I
> don't think we should land "isEmpty()" though.

Agreed hasInstances is better
Comment 5 youenn fablet 2022-05-02 07:11:04 PDT 
Created attachment 458678 [details]
Patch
Comment 6 EWS 2022-05-02 09:30:58 PDT 
Committed r293665 (250169@main): <https://commits.webkit.org/250169@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458678 [details].
Comment 7 Radar WebKit Bug Importer 2022-05-02 09:31:16 PDT 
<rdar://problem/92612581>