RESOLVED FIXED 239844
Resolve ::first-letter eagerly 
https://bugs.webkit.org/show_bug.cgi?id=239844
Summary Resolve ::first-letter eagerly
Antti Koivisto
Reported 2022-04-28 02:43:07 PDT
::first-letter pseudo-element should be resolved eagerly during style resolution, similar to ::first-line. This will clean up architecture and also make it animatable.
Attachments
Patch (52.92 KB, patch)
2022-04-28 03:09 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (56.79 KB, patch)
2022-04-28 04:39 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (56.64 KB, patch)
2022-04-28 04:56 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (56.67 KB, patch)
2022-04-28 05:02 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (56.82 KB, patch)
2022-04-28 06:43 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (61.28 KB, patch)
2022-05-02 02:34 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (61.28 KB, patch)
2022-05-02 02:36 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (61.47 KB, patch)
2022-05-02 03:50 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (55.15 KB, patch)
2022-05-16 03:08 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (60.44 KB, patch)
2022-05-16 04:29 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (60.44 KB, patch)
2022-05-16 07:28 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-04-28 03:09:38 PDT
Created attachment 458508 [details] Patch
Antti Koivisto
Comment 2 2022-04-28 04:39:01 PDT
Created attachment 458510 [details] Patch
Antti Koivisto
Comment 3 2022-04-28 04:56:02 PDT
Created attachment 458513 [details] Patch
Antti Koivisto
Comment 4 2022-04-28 05:02:54 PDT
Created attachment 458516 [details] Patch
Antti Koivisto
Comment 5 2022-04-28 06:43:17 PDT
Created attachment 458525 [details] Patch
zalan
Comment 6 2022-04-28 07:52:30 PDT
Comment on attachment 458525 [details] Patch nice cleanup on the expected.txt files!
Tim Nguyen (:ntim)
Comment 7 2022-04-28 09:44:08 PDT
Comment on attachment 458525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458525&action=review > LayoutTests/fast/css-generated-content/first-letter-in-nested-before.html:3 > + #target:before { display: div; content: "A"; } `display: div` is not correct here
Antti Koivisto
Comment 8 2022-05-02 02:34:44 PDT
Created attachment 458669 [details] Patch for landing
Antti Koivisto
Comment 9 2022-05-02 02:36:06 PDT
Created attachment 458670 [details] Patch
Antti Koivisto
Comment 10 2022-05-02 03:50:54 PDT
Created attachment 458672 [details] Patch
Radar WebKit Bug Importer
Comment 11 2022-05-05 02:44:13 PDT
<rdar://problem/92784656>
Antti Koivisto
Comment 12 2022-05-16 03:08:12 PDT
Created attachment 459410 [details] patch
Antti Koivisto
Comment 13 2022-05-16 04:29:30 PDT
Created attachment 459415 [details] patch
Antti Koivisto
Comment 14 2022-05-16 07:28:02 PDT
Created attachment 459423 [details] patch
EWS
Comment 15 2022-05-16 23:01:07 PDT
Committed r294291 (250633@main): <https://commits.webkit.org/250633@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459423 [details].
Philippe Normand
Comment 16 2022-05-17 08:15:59 PDT
This broke GTK, but no one watched the red bubbles it seems...
Antti Koivisto
Comment 17 2022-05-18 02:29:34 PDT
(In reply to Philippe Normand from comment #16) > This broke GTK, but no one watched the red bubbles it seems... Oops, sorry about that.
Note You need to log in before you can comment on or make changes to this bug.