DisplayList::Recorder should lazily create the DrawGlyphsRecorder
Created attachment 458475 [details] Patch
Comment on attachment 458475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458475&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:166 > + if (!m_drawGlyphsRecorder) > + m_drawGlyphsRecorder = makeUnique<DrawGlyphsRecorder>(*this, m_initialScale, m_deconstructDrawGlyphs); Can we pull this out into an ensure() function? > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:275 > + float m_initialScale { 1 }; > + DrawGlyphsRecorder::DeconstructDrawGlyphs m_deconstructDrawGlyphs { DrawGlyphsRecorder::DeconstructDrawGlyphs::No }; Should these be batched up into a struct? Are we polluting the contents of the Recorder object?
(In reply to Myles C. Maxfield from comment #2) > Comment on attachment 458475 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458475&action=review > > > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:166 > > + if (!m_drawGlyphsRecorder) > > + m_drawGlyphsRecorder = makeUnique<DrawGlyphsRecorder>(*this, m_initialScale, m_deconstructDrawGlyphs); > > Can we pull this out into an ensure() function? > > > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:275 > > + float m_initialScale { 1 }; > > + DrawGlyphsRecorder::DeconstructDrawGlyphs m_deconstructDrawGlyphs { DrawGlyphsRecorder::DeconstructDrawGlyphs::No }; > > Should these be batched up into a struct? Are we polluting the contents of > the Recorder object? Both true, but I'm not sure either are worth it.
<rdar://problem/92438193>
Committed r293572 (250086@main): <https://commits.webkit.org/250086@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458475 [details].