Bug 239808 - Make -webkit-transform-style an alias of transform-style
Summary: Make -webkit-transform-style an alias of transform-style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar, WPTImpact
Depends on:
Blocks: 240341 239579
  Show dependency treegraph
 
Reported: 2022-04-27 07:21 PDT by Tim Nguyen (:ntim)
Modified: 2022-05-12 08:37 PDT (History)
14 users (show)

See Also:


Attachments
Patch (9.74 KB, patch)
2022-04-27 08:36 PDT, Tim Nguyen (:ntim)
koivisto: review+
ntim: commit-queue-
Details | Formatted Diff | Diff
Patch (23.40 KB, patch)
2022-04-27 11:53 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-04-27 07:21:53 PDT
Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and simplifies code as well given the FIXME was never addressed.
Comment 1 Tim Nguyen (:ntim) 2022-04-27 08:36:23 PDT
Created attachment 458449 [details]
Patch
Comment 2 Oriol Brufau 2022-04-27 10:36:04 PDT
You will need to update the expectations for these tests:

fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
svg/css/getComputedStyle-basic.xhtml
Comment 3 Tim Nguyen (:ntim) 2022-04-27 11:53:39 PDT
Created attachment 458456 [details]
Patch
Comment 4 Tim Nguyen (:ntim) 2022-04-27 12:05:16 PDT
Committed r293524 (250055@trunk): <https://commits.webkit.org/250055@trunk>
Comment 5 Radar WebKit Bug Importer 2022-04-27 12:06:14 PDT
<rdar://problem/92412686>
Comment 6 EWS 2022-04-27 12:06:50 PDT
Found 5 new test failures: fast/css/getComputedStyle/computed-style-without-renderer.html, fast/css/getComputedStyle/computed-style.html, imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html, imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html, svg/css/getComputedStyle-basic.xhtml