Bug 239806 - [RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods
Summary: [RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} met...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 237775
  Show dependency tree / graph
 
Reported: 2022-04-27 00:55 PDT by Zan Dobersek
Modified: 2022-04-28 03:07 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.69 KB, patch)
2022-04-27 00:56 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (9.57 KB, patch)
2022-04-28 03:03 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2022-04-27 00:55:00 PDT 
[RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods
Comment 1 Zan Dobersek 2022-04-27 00:56:14 PDT 
Created attachment 458430 [details]
Patch
Comment 2 Yusuke Suzuki 2022-04-28 00:48:45 PDT 
Comment on attachment 458430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458430&action=review

r=me with nit.D

> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3366
> +        {
> +            Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero);
> +            failure.link(this);
> +            return JumpList(success);
> +        }

style is,

case Success: {
    ...
}

> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3405
> +        {
> +            Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero);
> +            failure.link(this);
> +            return JumpList(success);
> +        }

Ditto.

> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3432
> +        {
> +            Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero);
> +            failure.link(this);
> +            return JumpList(success);
> +        }

Ditto.
Comment 3 Zan Dobersek 2022-04-28 03:03:03 PDT 
Created attachment 458507 [details]
Patch for landing

With style changes.
Comment 4 Zan Dobersek 2022-04-28 03:06:53 PDT 
Comment on attachment 458507 [details]
Patch for landing

Clearing flags on attachment: 458507

Committed r293571 (250085@trunk): <https://commits.webkit.org/250085@trunk>
Comment 5 Zan Dobersek 2022-04-28 03:06:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2022-04-28 03:07:19 PDT 
<rdar://problem/92450245>