Bug 239806 – [RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods

[Zan Dobersek]

Created attachment 458430 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 458430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458430&action=review

r=me with nit.D

> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3366
> +        {
> +            Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero);
> +            failure.link(this);
> +            return JumpList(success);
> +        }

style is,

case Success: {
    ...
}

> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3405
> +        {
> +            Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero);
> +            failure.link(this);
> +            return JumpList(success);
> +        }

Ditto.

> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3432
> +        {
> +            Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero);
> +            failure.link(this);
> +            return JumpList(success);
> +        }

Ditto.

[Zan Dobersek]

Created attachment 458507 [details]
Patch for landing

With style changes.

[Zan Dobersek]

Comment on attachment 458507 [details]
Patch for landing

Clearing flags on attachment: 458507

Committed r293571 (250085@trunk): <https://commits.webkit.org/250085@trunk>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/92450245>