Bug 239788 – test-webkitpy TestInstallGitLFS fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Catanzaro]

I see two failures when running test-webkitpy:

[1571/2000] webkitscmpy.test.install_git_lfs_unittest.TestInstallGitLFS.test_no_repo failed:              
  Traceback (most recent call last):
    File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py", line 141, in test_no_repo
      self.assertEqual(0, program.main(
  AssertionError: 0 != 1
  
[1841/2000] webkitscmpy.test.install_git_lfs_unittest.TestInstallGitLFS.test_install failed:
  Traceback (most recent call last):
    File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py", line 83, in test_install
      self.assertEqual(0, program.main(
  AssertionError: 0 != 1

It's pretty suspicious:

    def test_install(self):
        with OutputCapture() as captured, mocks.remote.GitHub('github.com/git-lfs/git-lfs', releases={
            'v3.1.2/git-lfs-darwin-arm64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS),
            'v3.1.2/git-lfs-darwin-amd64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS),
        }), mocks.local.Git(self.path), mocks.local.Svn():
            self.assertIsNone(local.Git(self.path).config().get('lfs.repositoryformatversion'))
            self.assertEqual(0, program.main(
                args=('install-git-lfs',),
                path=self.path,
            ))
            self.assertEqual(local.Git(self.path).config()['lfs.repositoryformatversion'], '0')

Looks like it's trying to install macOS binaries?

[Radar WebKit Bug Importer]

<rdar://problem/92363359>

[Jonathan Bedard]

Pull request: https://github.com/WebKit/WebKit/pull/404

[EWS]

Committed r293515 (250046@main): <https://commits.webkit.org/250046@main>

Reviewed commits have been landed. Closing PR #404 and removing active labels.