Bug 239787 – AXObjectCache::childrenChanged modifies m_deferred* member variables but doesn't start timer to process them

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

AXObjectCache::childrenChanged modifies m_deferred* member variables but doesn't start timer to process them

[Radar WebKit Bug Importer]

<rdar://problem/92354189>

[Tyler Wilcock]

Created attachment 458405 [details]
Patch

[chris fleizach]

Comment on attachment 458405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458405&action=review

> Source/WebCore/ChangeLog:13
> +        m_deferredNodeAdditionOrRemovalList, since this more accurately

can we make this name shorter. something like
m_deferredNodeChangeList

> Source/WebCore/accessibility/AXObjectCache.cpp:1123
>      if (!renderer)

can we make this method call into childrenChange(Node*) instead of duplicating code?

[Tyler Wilcock]

Created attachment 458447 [details]
Patch

[Tyler Wilcock]

> > Source/WebCore/ChangeLog:13
> > +        m_deferredNodeAdditionOrRemovalList, since this more accurately
> 
> can we make this name shorter. something like
> m_deferredNodeChangeList
To me, "node change list" is a little too vague, as that could encompass any change (e.g. an attribute change). I made it slightly shorter with m_deferredNodeAddedOrRemovedList.

> > Source/WebCore/accessibility/AXObjectCache.cpp:1123
> >      if (!renderer)
> 
> can we make this method call into childrenChange(Node*) instead of
> duplicating code?
We could do that if we can assume every renderer has a node, but I personally don't feel comfortable making that assumption since the opposite assumption has bitten us (every node having a renderer).

I refactored in other ways (including a new deferNodeAddedOrRemoved method that I'll add to in a later modal patch) to reduce duplication.

[EWS]

Committed r293566 (250080@main): <https://commits.webkit.org/250080@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458447 [details].