Bug 239782 - REGRESSION (r293117): Context menu lift animation encompasses the entire web view
Summary: REGRESSION (r293117): Context menu lift animation encompasses the entire web ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-26 12:06 PDT by Wenson Hsieh
Modified: 2022-04-26 14:25 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.42 KB, patch)
2022-04-26 12:08 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (2.30 KB, patch)
2022-04-26 12:40 PDT, Wenson Hsieh
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-04-26 12:06:03 PDT
rdar://92342919
Comment 1 Wenson Hsieh 2022-04-26 12:08:42 PDT
Created attachment 458387 [details]
Patch
Comment 2 Aditya Keerthi 2022-04-26 12:19:40 PDT
Comment on attachment 458387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458387&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-11898
> -- (UITargetedPreview *)contextMenuInteraction:(UIContextMenuInteraction *)interaction configuration:(UIContextMenuConfiguration *)configuration previewForHighlightingItemWithIdentifier:(id<NSCopying>)identifier

The bug is probably due to using `previewForHighlightingItemWithIdentifier` rather than `highlightPreviewForItemWithIdentifier` here.

But fine to revert if we need an immediate fix.
Comment 3 Wenson Hsieh 2022-04-26 12:20:45 PDT
(In reply to Aditya Keerthi from comment #2)
> Comment on attachment 458387 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458387&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-11898
> > -- (UITargetedPreview *)contextMenuInteraction:(UIContextMenuInteraction *)interaction configuration:(UIContextMenuConfiguration *)configuration previewForHighlightingItemWithIdentifier:(id<NSCopying>)identifier
> 
> The bug is probably due to using `previewForHighlightingItemWithIdentifier`
> rather than `highlightPreviewForItemWithIdentifier` here.
> 
> But fine to revert if we need an immediate fix.

Yep! I'm checking to make sure that just moving to `-highlightPreviewForItemWithIdentifier` fixes this. If so, I'll land a version of the patch that just adopts the new method.
Comment 4 Wenson Hsieh 2022-04-26 12:40:45 PDT
Created attachment 458388 [details]
Patch
Comment 5 EWS 2022-04-26 14:19:15 PDT
Tools/Scripts/svn-apply failed to apply attachment 458388 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Wenson Hsieh 2022-04-26 14:25:40 PDT
Committed r293448: <https://commits.webkit.org/r293448>