RESOLVED FIXED Bug 239685
Replace String::replace() functions with makeStringByReplacingAll() free functions 
https://bugs.webkit.org/show_bug.cgi?id=239685
Summary Replace String::replace() functions with makeStringByReplacingAll() free func...
Chris Dumez
Reported 2022-04-22 21:24:12 PDT
Replace String::replace() functions with makeStringByReplacingAll() free functions. "All" is added to the name since every instance is replaced, not just the first one. Making it a free function that returns a new String is a step towards making String immutable. In the future, we may want to add a makeStringByReplacingAll() that takes in a StringView instead of a `const String`. Some call sites would benefit from that.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-04-22 22:08:05 PDT
Pull request: https://github.com/WebKit/WebKit/pull/368
EWS
Comment 2 2022-04-25 08:26:03 PDT
Committed r293326 (249949@main): <https://commits.webkit.org/249949@main> Reviewed commits have been landed. Closing PR #368 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-04-25 08:27:14 PDT
<rdar://problem/92270440>
Note You need to log in before you can comment on or make changes to this bug.