RESOLVED FIXED Bug 239681
[Xcode] Compute PGO profdata paths instead of searching for them at build time 
https://bugs.webkit.org/show_bug.cgi?id=239681
Summary [Xcode] Compute PGO profdata paths instead of searching for them at build time
Elliott Williams
Reported 2022-04-22 18:09:46 PDT
Currently, the "Copy Profiling Data" script phases find profdata to use by checking BUILT_PRODUCTS_DIR, then the SDK, and finally falling back to the default profdata stub in SRCROOT. This can cause problems if stale profdata is present in BUILT_PRODUCTS_DIR and a production build is updating SDK content. It also confuses XCBuild's dependency validation on open-source builds, because the build system expects the SDK and WebKitAdditions paths to always exist. Instead of this dynamic approach, we can compute the expected path in xcconfigs, based on the active build settings.
Attachments
Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2022-04-22 18:23:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/367
Radar WebKit Bug Importer
Comment 2 2022-04-22 18:30:04 PDT
<rdar://problem/92200351>
Elliott Williams
Comment 3 2022-04-23 13:34:56 PDT
Pull request: https://github.com/WebKit/WebKit/pull/369
EWS
Comment 4 2022-04-26 12:21:12 PDT
Committed r293442 (249997@main): <https://commits.webkit.org/249997@main> Reviewed commits have been landed. Closing PR #367 and removing active labels.
WebKit Commit Bot
Comment 5 2022-04-26 16:37:23 PDT
Re-opened since this is blocked by bug 239795
Elliott Williams
Comment 6 2022-05-25 16:26:00 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1031
EWS
Comment 7 2022-05-27 14:11:36 PDT
Committed r294952 (251060@main): <https://commits.webkit.org/251060@main> Reviewed commits have been landed. Closing PR #1031 and removing active labels.
Alexey Proskuryakov
Comment 8 2022-05-30 19:13:47 PDT
This patch was reverted in https://commits.webkit.org/251100@main
Elliott Williams
Comment 9 2022-05-30 20:09:05 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1171
EWS
Comment 10 2022-05-31 14:19:29 PDT
Committed r295065 (251160@main): <https://commits.webkit.org/251160@main> Reviewed commits have been landed. Closing PR #1171 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.