Bug 239677 - Web Inspector: request interception should not be guarded based on service workers
Summary: Web Inspector: request interception should not be guarded based on service wo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-22 16:48 PDT by Devin Rousso
Modified: 2022-04-25 16:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.46 KB, patch)
2022-04-22 16:57 PDT, Devin Rousso
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.52 KB, patch)
2022-04-22 21:48 PDT, Devin Rousso
pangle: review+
Details | Formatted Diff | Diff
Patch (14.57 KB, patch)
2022-04-25 11:08 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-04-22 16:48:55 PDT
.
Comment 1 Devin Rousso 2022-04-22 16:57:26 PDT
Created attachment 458188 [details]
Patch
Comment 2 Devin Rousso 2022-04-22 21:48:11 PDT
Created attachment 458201 [details]
Patch
Comment 3 Patrick Angle 2022-04-23 10:25:46 PDT
Comment on attachment 458201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458201&action=review

r=me

> Source/WebCore/inspector/InspectorInstrumentation.cpp:848
> +bool InspectorInstrumentation::shouldInterceptRequestImpl(InstrumentingAgents& instrumentingAgents, ResourceLoader& loader)

As far as I can tell, everything we do with the ResourceLoader can be done with a const ref – is there a reason we aren't passing `const ResourceLoader&` throughout instead?

> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:1121
> +    return shouldIntercept(loader.request().url(), Protocol::Network::NetworkStage::Request);

Nit: I think we can just `loader.url()`
Comment 4 Devin Rousso 2022-04-25 11:08:43 PDT
Created attachment 458285 [details]
Patch
Comment 5 EWS 2022-04-25 16:15:30 PDT
Committed r293368 (249968@main): <https://commits.webkit.org/249968@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458285 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-25 16:16:16 PDT
<rdar://problem/92300532>