Bug 239676 - Web Inspector: response overrides with an error status code should indicate that somewhere
Summary: Web Inspector: response overrides with an error status code should indicate t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-22 16:44 PDT by Devin Rousso
Modified: 2022-04-25 12:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2022-04-22 16:47 PDT, Devin Rousso 		pangle: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.96 KB, patch)
2022-04-25 11:08 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-04-22 16:44:07 PDT 
it's odd that the local override shows as regular "text" when resources loaded from it have error (i.e. red) "text"
Comment 1 Devin Rousso 2022-04-22 16:47:40 PDT 
Created attachment 458187 [details]
Patch
Comment 2 Patrick Angle 2022-04-22 17:03:46 PDT 
Comment on attachment 458187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458187&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js:111
>          // Do nothing. Do not allow ResourceTreeElement / SourceCodeTreeElement to modify our status element.

I think the "Do nothing" part of this is contradicted now 😅. (As an aside, I had to read this comment a few times before I realized it was trying to explain why we don't let `super` be called.)
Comment 3 Devin Rousso 2022-04-25 11:08:08 PDT 
Created attachment 458284 [details]
Patch
Comment 4 EWS 2022-04-25 12:55:21 PDT 
Committed r293338 (249959@main): <https://commits.webkit.org/249959@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458284 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-25 12:56:13 PDT 
<rdar://problem/92288790>