Bug 239675 - Web Inspector: crash when using a skip network local override that has an error status code
Summary: Web Inspector: crash when using a skip network local override that has an err...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-22 16:37 PDT by Devin Rousso
Modified: 2022-04-25 15:58 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2022-04-22 16:43 PDT, Devin Rousso 		pangle: review+
Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2022-04-25 11:07 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-04-22 16:37:57 PDT 
.
Comment 1 Devin Rousso 2022-04-22 16:43:26 PDT 
Created attachment 458186 [details]
Patch
Comment 2 Patrick Angle 2022-04-22 16:50:10 PDT 
Comment on attachment 458186 [details]
Patch

r=me – Is this testable?
Comment 3 Devin Rousso 2022-04-25 11:07:41 PDT 
Created attachment 458283 [details]
Patch

(In reply to Patrick Angle from comment #2)
> r=me – Is this testable?

yup, I just forgot to `git add` before I `webkit-patch upload` 😅
Comment 4 Patrick Angle 2022-04-25 11:31:31 PDT 
Comment on attachment 458283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458283&action=review

> LayoutTests/http/tests/inspector/network/intercept-request-subresource-with-response-error-status-code.html:19
> +                responseStatusCode: 418,

🤣
Comment 5 EWS 2022-04-25 15:57:18 PDT 
Committed r293367 (249967@main): <https://commits.webkit.org/249967@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458283 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-25 15:58:15 PDT 
<rdar://problem/92299551>