Bug 239657 – service worker update should refresh imported scripts in addition to the main script

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

service worker update should refresh imported scripts in addition to the main script

[youenn fablet]

Created attachment 458156 [details]
Patch

[youenn fablet]

Created attachment 458260 [details]
Patch

[youenn fablet]

Created attachment 458263 [details]
Patch

[Chris Dumez]

Comment on attachment 458263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458263&action=review

r=me

> Source/WebCore/workers/service/server/SWServer.cpp:567
> +            m_scripts.append(std::make_pair(url, WTFMove(result.script)));

Can probably just:
m_scripts.append({ url, WTFMove(result.script) });

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:114
> +        RELEASE_LOG(ServiceWorker, "%p - SWServerJobQueue::scriptFetchFinished, script, certificate and imported scripts are matching for registrationID=%llu", this, registration->identifier().toUInt64());

%llu -> PRIu64

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:135
> +        RELEASE_LOG(ServiceWorker, "%p - SWServerJobQueue::importedScriptsFetchFinished, script, certificate and imported scripts are matching for registrationID=%llu", this, registration->identifier().toUInt64());

PRIu64

[youenn fablet]

Created attachment 458426 [details]
Patch

[EWS]

Committed r293506 (250037@main): <https://commits.webkit.org/250037@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458426 [details].

[Radar WebKit Bug Importer]

<rdar://problem/92393337>