Bug 239646 - Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore
Summary: Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent any...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-22 02:55 PDT by Kimmo Kinnunen
Modified: 2022-08-02 00:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2022-04-22 02:58 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2022-04-26 00:11 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-04-22 02:55:33 PDT 
Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore
Comment 1 Kimmo Kinnunen 2022-04-22 02:58:59 PDT 
Created attachment 458127 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-04-26 00:11:32 PDT 
Created attachment 458334 [details]
Patch
Comment 3 EWS 2022-04-26 22:41:39 PDT 
Committed r293498 (250031@main): <https://commits.webkit.org/250031@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458334 [details].
Comment 4 Radar WebKit Bug Importer 2022-04-26 22:42:12 PDT 
<rdar://problem/92378815>
Comment 5 Darin Adler 2022-04-27 14:21:03 PDT 
Comment on attachment 458334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review

> Tools/Scripts/VCSUtils.pm:-856
> -        # The first and second paths can differ in the case of copies
> -        # and renames.  We use the second file path because it is the
> -        # destination path.

Just noticed this comment. Was there a reason to remove it?
Comment 6 Kimmo Kinnunen 2022-04-28 03:58:15 PDT 
Comment on attachment 458334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review

>> Tools/Scripts/VCSUtils.pm:-856
>> -        # destination path.
> 
> Just noticed this comment. Was there a reason to remove it?

It's a stale comment from the era when the logic of parseGitDiffStartLine was inline in this function, and the regex extracted both the first path and second path from the match.

There's no "first path" nor "second path" in this context anymore.

parseGitDiffStartLine documents that it returns the destination file for each  file diff section in a git patch.

bug 38628