Bug 239628 - Remove XSS Auditor: Part 4 (Settings)
Summary: Remove XSS Auditor: Part 4 (Settings)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-21 16:00 PDT by Brent Fulgham
Modified: 2022-04-21 19:49 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.82 KB, patch)
2022-04-21 16:03 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch for landing (4.35 KB, patch)
2022-04-21 18:06 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-04-21 16:00:56 PDT
When working on Bug 230661 I neglected to remove the WebPreferences.yaml bits of the feature.

This patch removes those bits, but still leaves the deprecated stub methods on WKPreferencesRef and WebPreferencesPrivate to avoid breaking any existing binaries that might reference those methods.
Comment 1 Brent Fulgham 2022-04-21 16:03:40 PDT
Created attachment 458100 [details]
Patch
Comment 2 Yusuke Suzuki 2022-04-21 16:54:52 PDT
👍 Nice!!
Comment 3 EWS 2022-04-21 17:06:17 PDT
Committed r293199 (249872@main): <https://commits.webkit.org/249872@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458100 [details].
Comment 4 Radar WebKit Bug Importer 2022-04-21 17:07:15 PDT
<rdar://problem/92131006>
Comment 5 Brent Fulgham 2022-04-21 18:06:26 PDT
Reopening to attach new patch.
Comment 6 Brent Fulgham 2022-04-21 18:06:28 PDT
Created attachment 458107 [details]
Patch for landing
Comment 7 Brent Fulgham 2022-04-21 18:58:16 PDT
I did not properly account for Windows in the first patch, so have corrected that in a follow-up.
Comment 8 EWS 2022-04-21 19:49:49 PDT
Committed r293205 (249876@main): <https://commits.webkit.org/249876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458107 [details].